New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update i18n docs to reflect v7 changes #705
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d751903:
|
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 119 119
Lines 6929 6929
Branches 1573 1573
=======================================
Hits 6774 6774
Misses 155 155
Continue to review full report at Codecov.
|
@mwistrand I will update zh-CN docs. |
@mwistrand Do you think we need to keep a section on the build tooling? Covering the |
- Replace references of the old `i18n` function with `localizeBundle()`. - Remove references to CLDR data as these data are now injected at build time. - Remove references to `setLocaleMessages` and `getCachedMessages`. - Replace message formatter examples with `format` examples. - Update documentation on reading the current locale.
@agubler There is already a "Configuring supported application locales" section beneath the top-level "Internationalizing a Dojo application" page that describes the |
Should we mention on that page that without the locale then i18n will only use root bundles and do non icu message formatting? Or do we think that's enough? |
That's not a bad idea. I'll update to include that warning. |
c6a5cfa
to
d751903
Compare
- Replace references of the old `i18n` function with `localizeBundle()`. - Remove references to CLDR data as these data are now injected at build time. - Remove references to `setLocaleMessages` and `getCachedMessages`. - Replace message formatter examples with `format` examples. - Update documentation on reading the current locale. - Include warning about failing to specify a default locale.
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Resolves #698
Unfortunately, as I cannot read Chinese, the corresponding
zh-CN
docs are left untouched.i18n
function withlocalizeBundle()
.setLocaleMessages
andgetCachedMessages
.format
examples.