Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6-string-raw is always false #78

Closed
dasa opened this issue Aug 21, 2018 · 0 comments · Fixed by #88
Closed

es6-string-raw is always false #78

dasa opened this issue Aug 21, 2018 · 0 comments · Fixed by #88

Comments

@dasa
Copy link
Contributor

dasa commented Aug 21, 2018

Bug

shim/string isn't using the native functions like startsWith since the has test es6-string-raw is always false. Tested in Chrome, Edge, Firefox, and Safari where es6-string was true.

This seems like a sniff bug, but if not, then shim/string should be updated to not require es6-string and es6-string-raw to both be true before using the available native ES6 functions at:
https://github.com/dojo/framework/blob/master/src/shim/string.ts#L144

Package Version

3.0.1

Code

Console code using Dojo 1 AMD loader after loading shim/string:

require("@dojo/framework/has/has").default("es6-string-raw")

Expected behavior:

outputs true

Actual behavior:

outputs false

@rorticus rorticus mentioned this issue Aug 29, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant