Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme review #25

Closed
tomdye opened this issue Feb 9, 2018 · 2 comments
Closed

Readme review #25

tomdye opened this issue Feb 9, 2018 · 2 comments
Assignees
@tomdye
Milestone
rc.2

Comments

@tomdye
Copy link
Member

tomdye commented Feb 9, 2018

  • DijitWrapper example
    • _onCalendarChange does not need to be an arrow function
  • ReduxInjector example
    • Perhaps change the imports to use the default exports
@agubler
Copy link
Member

agubler commented Feb 9, 2018

Sounds good, let's also add the TOC for the README (to be consistent with all the others) and put protected for the render in the example

@agubler
Copy link
Member

agubler commented Feb 9, 2018

Also the section for third party libs at the bottom is just the default... should update that.

@tomdye tomdye mentioned this issue Feb 9, 2018
Merged
3 tasks
@dylans dylans added this to the rc.2 milestone Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomdye tomdye

Labels
None yet
Projects
None yet
Milestone
rc.2
Development

No branches or pull requests
3 participants
@dylans @tomdye @agubler