Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-721 Metadata hook #80

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

rsodre
Copy link

@rsodre rsodre commented Jun 29, 2024

Closes #79

Introduced changes

Breaking changes

Contracts that do not implement this hook are required to import ERC721MetadataHooksEmptyImpl.

use token::components::token::erc721::erc721_metadata::erc721_metadata_component;
use token::components::token::erc721::erc721_metadata_hooks::ERC721MetadataHooksEmptyImpl;

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Updated relevant presets
  • Added relevant tests
  • Add a dedicated CI job for new examples
  • Performed self-review of the code

@rsodre rsodre force-pushed the metadata-hook branch 5 times, most recently from c8b99bc to 071d941 Compare June 30, 2024 02:09
@rsodre rsodre marked this pull request as ready for review June 30, 2024 02:43
@rsodre
Copy link
Author

rsodre commented Jul 7, 2024

@notV4l , what do you think about this?
custom uris are necessary.
if you have a better alternative let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC-721 Metadata hooks
1 participant