Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CreateFile SharedAccess #152

Closed
Liryna opened this issue Feb 1, 2016 · 4 comments
Closed

Implement CreateFile SharedAccess #152

Liryna opened this issue Feb 1, 2016 · 4 comments

Comments

@Liryna
Copy link
Member

Liryna commented Feb 1, 2016

Dokan should have a option to make the driver check the file sharedaccess request before forwarding the request to the library.
This will give the ability for the user to not implement his own checks.

See #32
Begining of implementation marinkobabic/dokanx@888bd0d

@Corillian
Copy link

Implementing this correctly under all circumstances in my own driver has proved quite frustrating as the documentation is not always clear under which conditions a set of flags should be checked:

https://msdn.microsoft.com/en-us/library/windows/desktop/aa363874(v=vs.85).aspx
https://msdn.microsoft.com/en-us/library/windows/hardware/aa364399(v=vs.85).aspx
https://msdn.microsoft.com/en-us/library/windows/hardware/ff540466(v=vs.85).aspx

I suspect the best way to approach this will be to lookup how it's handled in Microsoft's driver examples such as FastFAT: https://github.com/Microsoft/Windows-driver-samples/tree/master/filesys/fastfat

@Maxhy
Copy link
Member

Maxhy commented May 10, 2016

In addition to @marinkobabic tests, latest oplock changes first attempted to also implement shared access. The code is currently partially implemented and commented, see https://github.com/dokan-dev/dokany/blob/master/sys/create.c#L829

@Liryna
Copy link
Member Author

Liryna commented Aug 20, 2016

DokanCheckShareAccess has been fixed and enabled. It seems to work with issues but more testing should be done to be sure that all cases are handled.

@Liryna
Copy link
Member Author

Liryna commented Nov 18, 2017

IFSTest ShareAccessTest pass 👍 all seems to be good !

@Liryna Liryna closed this as completed Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants