Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation unit size as option #164

Closed
Liryna opened this issue Feb 12, 2016 · 4 comments
Closed

Allocation unit size as option #164

Liryna opened this issue Feb 12, 2016 · 4 comments

Comments

@Liryna
Copy link
Member

Liryna commented Feb 12, 2016

We should be able to set the allocation unit size of the device as a DokanOption or during the Mount.
DOKAN_ALLOCATION_UNIT_SIZE DOKAN_SECTOR_SIZE
The value should also be checked to fit the windows FAT/NTFS value:
https://support.microsoft.com/en-us/kb/140365

@Liryna Liryna changed the title Allocation unit size a option Allocation unit size as option Feb 23, 2016
@Liryna
Copy link
Member Author

Liryna commented Mar 15, 2016

Hi @marinkobabic ,

I am currently looking for this ticket to integrate it in the 1.0.0.

I was thinking that DOKAN_SECTOR_SIZE was only used in the library but it seems like in the kernel also...

DOKAN_DISK_SIZE / DOKAN_SECTOR_SIZE / 32 / 2;

DOKAN_DISK_SIZE; // Partition size equels disk size here

For me the DokanPopulateDiskGeometry and DiskDeviceControl are strange because they use DOKAN_DISK_SIZE that could be incorrect if the user has set his own size.

Do you think the values should be updated ? for now it don't seems to create an issue 😄

@Liryna
Copy link
Member Author

Liryna commented Mar 15, 2016

@marinkobabic
Copy link
Contributor

@Liryna You are right, but the information is displayed in explorer is the volume size which is updated by the user. Makes not a big difference if you update the disk information or not. Usually a volume can be created over one or more disks.

@Liryna
Copy link
Member Author

Liryna commented Mar 15, 2016

Thank you for your input @marinkobabic !
Therefore I have changed nothing in the kernel.

This has been done and can be tested with mirror option by creating a file with 1 byte and observing the real file size changing depending of the value used.
4ab27c6

@Liryna Liryna closed this as completed Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants