Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document type #168

Open
strugee opened this issue Apr 16, 2024 · 2 comments
Open

Document type #168

strugee opened this issue Apr 16, 2024 · 2 comments

Comments

@strugee
Copy link

strugee commented Apr 16, 2024

Description of feature

Both the README and https://dokku.com/docs/deployment/zero-downtime-deploys/ state that type may be one of startup, readiness, or liveness, but they don't actually say what this means! It would be nice to have this information available.

@erickedji
Copy link

Seems to refer to this, but not sure if applied to local docker outside of the default startup type: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

@josegonzalez
Copy link
Member

Yeah it refers to that, but the docker-local scheduler only supports the startup type. All are supported for the k3s scheduler.

In the future, the custom proxy plugins might enable some sort of support for the readiness type so that they don't proxy to things that can't be proxied to yet. We might also finally have a proper daemon that does healthchecks for the docker-local scheduler and handles restarts appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants