Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for letsecrypt wildcard certificates #147

Closed
RealOrangeOne opened this issue Mar 14, 2018 · 6 comments
Closed

Support for letsecrypt wildcard certificates #147

RealOrangeOne opened this issue Mar 14, 2018 · 6 comments

Comments

@RealOrangeOne
Copy link

RealOrangeOne commented Mar 14, 2018

https://community.letsencrypt.org/t/acme-v2-production-environment-wildcards/55578

I believe the only changes which need to be made are upgrading the certbot client, and specifying the V2 server.

This is especially useful for the default app feature (unknown subdomain), which means we can finally have a default app over SSL

@pdutourgeerling
Copy link

pdutourgeerling commented Mar 15, 2018

It looks like a lot of work to me. Besides requiring ACME v2, LE also requires the DNS-01 challenge for wildcard certificates.

dokku-letsencrypt currently uses simp_le which doesn’t support the DNS-01 challenge, and ACME v2 yet. They are planning to add support for ACME v2, but not DNS-01. See zenhack/simp_le#101.

If simp_le chooses to support DNS-01 or dokku-letsencrypt decides to use another LE client, it still needs to implement a way to automate DNS-01.

Please correct me if I’m wrong.

@mtzfactory
Copy link

It would be nice to have this feature...
;-)

@joshmanders
Copy link
Contributor

@mtzfactory Pull requests are welcome.

@almereyda
Copy link

simp_le has implemented ACME v2 with zenhack/simp_le#119. #101 there has since been closed.

Yet the manifest https://github.com/zenhack/simp_le#manifest states in point 3. that only http-01 will be supported. In nginx-proxy/acme-companion#319 (comment) they are considering to switch to acme.sh and implement the dns-01 challange through it.

@dean1012
Copy link
Contributor

This should be done as part of #183 (comment)

If no one sees any issues, this can be closed.

@josegonzalez
Copy link
Member

Closed as part of work from @dean1012 in #183.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants