Cosmetic changes #148
Merged
Cosmetic changes #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the contrib, looks like awesome work - I'm hoping to review and merge some time next week.
As for the upcoming release: there are some smaller issues still open for the 0.6 milestone. I hoped to have fixed them several months ago but have not gotten to it.
As I have to upgrade one of my customers sites to a newer Django release I can assure you an upcoming release will be made within about six weeks - or whenever these outstanding issues have been solved.
Regarding Django support: I do not intend to support any Django versions which are not officially supported. Hence, please feel free to submit a PR dropping support for <1.7 or just wait for me to do it some time soon.
Lastly, as has become evident, I do not have enough time to give this package the love and attention is requires. Hence, from the upcoming release onwards I will explicitly give the project up for adoption. Should you be interested in taking over part of the responsibilities with maintenance, please let me know!
|
|
Sure, I'll give it some love and attention and you should see a PR in the coming weeks. I have some other packages I maintain, so I have to split time a bit. I've been browsing through the issues a bit and I think I would be able to tackle some, when I don't have any pressing matters for clients ofcourse. We'll be in touch. |
|
I've just officially dropped support for any unsupported Django versions. Looking forward to any PR's you might have. Though, if you start working on something, please make sure there's an issue so we don't end up working on the same things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to upgrade a project to 1.7 and ran into issues with newsletter 0.5.2, so decided to fork and fix it. Luckily, I saw that some efforts were already done.
This PR reorganizes the imports a bit for a better coding style (group django imports alphabetically, then other third party libraries and then local imports), some small changes that my linter was complaining about and I removed the
contrib.auth.models.Userimport as you can figure it out from settings.AUTH_USER_MODEL anyway.I'd suggest dropping the AUTH_USER_MODEL shims alltogether and just use the setting, and mark 0.6 and up only available for Django 1.7 and up. That also enables you to drop South support.
I've also changed the testrunner to use the Discover runner where possible, and only fallback if needed. If you'd drop <1.7 support, that can also be removed.
Any idea when 0.6 might be on PyPI?