-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django 2.2 and 3.0 Support #300
Add Django 2.2 and 3.0 Support #300
Conversation
Standardizing comment formatting Removing sudo (not used by travis) Explicity delcaring an OS as per Travis recommendations
… to 3.0 support Adding coverage to dev packages to allow testing in dev environment
Removing warning test as new functionality will fail with no messages
Question to be resolved: is it acceptable to continue with |
Great work! I'll try and review it ASAP.
Thanks again! |
Wow! Such a clean contribution! I've already reviewed it, there's only one comment, really: Please add comments in the Travis file as well as in the Lastly, once the patch has been reviewed, I would appreciate if you could do a |
Thanks for catching that - I learned that I think I have got a simple enough fix working now that resolves those noted issues and we can easily pull it out once a new With these changes passing CI, I have also gone and updated the lockfile as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would request you find a way not to hardcode the line number in setup.py
, please see comment.
Pinning to the specific 12.6.0 release commit
Removing "-e " from the DEPENDENCY_LINKS
Major changes to allow Django 3.0 support
python_2_unicode_compatible
to thesix
library, as it is removed from Django.patch_logger
(from Django) tests toassertLogs
(fromunittest
), aspatch_logger
functionality is being dropped by Django.assertLogs
in Python 2.7; once Python 2.7 support is dropped this mixin can be removed and all tests should continue to pass.sorl-thumbnail
to a specific commit that supports Django 1.11 to Django 3.0 - intent would be for this to be returned back to a released version as soon as the next release is made.Other minor changes
.travis.yml
to remove unused statements and add recommended statements.Relevant Issues: #291 #295 #296 #299