Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust $ID instead of adjusting the instructions #110

Open
michitux opened this issue Apr 20, 2013 · 1 comment
Open

Adjust $ID instead of adjusting the instructions #110

michitux opened this issue Apr 20, 2013 · 1 comment

Comments

@michitux
Copy link
Member

It might be worth an experiment to simply adjust $ID to the included page instead of adjusting every single link, media reference, plugin instruction, ... The advantage would be that all relative links work and a lot less link fixing would be needed. The disadvantage might be that plugins that use external data storage would write or read the data of the included page which might lead to inconsistencies but could also have advantages as quite often it is not wanted that this data is stored for the including page.

This could be easily implemented in the include syntax part but then this wouldn't work for other plugins like the blog plugin that use the include plugin as helper plugin. A more robust solution might be to add this functionality to the wrap syntax that is dynamically added by the include plugin.

@michitux
Copy link
Member Author

A note for anybody who wants to work on this: This change probably won't be as good as I originally thought it was. I tried implementing this some time ago and had to notice that this creates many problems. Unfortunately I can't remember what these problems were exactly. Nevertheless this shall be a warning to first check if this really works and doesn't break everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant