Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argon2i hash support (needed to AuthPDO against nextcloud 16.x) #2956

Closed
einhirn opened this issue Jan 9, 2020 · 2 comments · Fixed by #2957
Closed

Argon2i hash support (needed to AuthPDO against nextcloud 16.x) #2956

einhirn opened this issue Jan 9, 2020 · 2 comments · Fixed by #2957

Comments

@einhirn
Copy link
Contributor

einhirn commented Jan 9, 2020

I want to AuthPDO against our nextcloud database, but they are using Argon2i hashes. Now it seems that I'll have to patch "inc/PassHash.php" to support that, am I correct? I'll give it a spin and try to create a pull request.

@einhirn
Copy link
Contributor Author

einhirn commented Jan 9, 2020

Is there a particular reason for not using php's own password_hash / password_verify functions - other than support for legacy PHP versions and/or special password hash schemes not supported by the native functions?

@phy25
Copy link
Collaborator

phy25 commented Jan 9, 2020

Is there a particular reason for not using php's own password_hash / password_verify functions - other than support for legacy PHP versions and/or special password hash schemes not supported by the native functions?

If you git blame those code you will see how old they are - DokuWiki currently supports PHP 5.6+ but these legacy code hasn't been refactored to make full use of the new features. (We also use legacy fallback JSON library now if I remembered correctly 😂)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants