Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap XML is broken #3134

Closed
nfriedli opened this issue Jun 4, 2020 · 7 comments
Closed

Sitemap XML is broken #3134

nfriedli opened this issue Jun 4, 2020 · 7 comments

Comments

@nfriedli
Copy link
Contributor

nfriedli commented Jun 4, 2020

In my "Hogfather" RC2 relsease, the automatic sitemap.xml?do=sitemap seems to be broken.
My DokuWiki is vanilla, no hacks, no extra plugins.

Fatal error:  Uncaught Error: Call to undefined method dokuwiki\Action\Sitemap::getFilePath() in [...]/inc/Action/Sitemap.php:35

Stack trace:
#0 [...]/inc/ActionRouter.php(83): dokuwiki\Action\Sitemap->preProcess()
#1 [...]/inc/ActionRouter.php(48): dokuwiki\ActionRouter->setupAction('sitemap')
#2 [...]/inc/ActionRouter.php(60): dokuwiki\ActionRouter->__construct()
#3 [...]/inc/actions.php(16): dokuwiki\ActionRouter::getInstance(true)
#4 [...]/doku.php(122): act_dispatch()
#5 {main} thrown in [...]/inc/Action/Sitemap.php on line 35
@Klap-in
Copy link
Collaborator

Klap-in commented Jun 4, 2020

@wisze
Copy link

wisze commented Sep 4, 2020

Since upgrading to Hogfather the sitemap.xml does not seem to be updated. New pages do not appear, timestamp of the file is not updated. I made sure the existing sitemap.xml.gz file permissions allow it to be written.

@phy25
Copy link
Collaborator

phy25 commented Sep 7, 2020

@wisze It's working for me fine. Could you create a new issue with more information about your environment and settings, or seek help on https://forum.dokuwiki.org/?

If your sitemap won't be created you can try to get some debug output from the indexer by calling http://yourserver/dokuwiki/lib/exe/indexer.php?debug=1 in your browser.

https://www.dokuwiki.org/sitemap

@wisze
Copy link

wisze commented Sep 10, 2020

There appears to be a link to spatialhelper. My error log:

wiki.wisze.net/lib/plugins/spatialhelper/action.php:133\nStack trace:\n#0 /var/www/vhosts/wisze.net/wiki.wisze.net/inc/Extension/EventHandler.php(81): action_plugin_spatialhelper->handle_sitemap_generate_before(Object(dokuwiki\\Extension\\Event), NULL)\n#1 /var/www/vhosts/wisze.net/wiki.wisze.net/inc/Extension/Event.php(72): dokuwiki\\Extension\\EventHandler->process_event(Object(dokuwiki\\Extension\\Event), 'BEFORE')\n#2 /var/www/vhosts/wisze.net/wiki.wisze.net/inc/Sitemap/Mapper.php(68): dokuwiki\\Extension\\Event->advise_before(true)\n#3 /var/www/vhosts/wisze.net/wiki.wisze.net/inc/TaskRunner.php(213): dokuwiki\\Sitemap\\Mapper::generate()\n#4 /var/www/vhosts/wisze.net/wiki.wisze.net/inc/TaskRunner.php(50): dokuwiki\\TaskRunner->runSitemapper()\n#5 /var/www/vhosts/wisze.net/wiki.wisze.net/lib/exe/taskrunner.php(16): dokuwiki\\TaskRunner->run()\n#6 /var/www/vhosts/wisze.net/wiki.wisze.net/lib/exe/indexer.php(5)...'

@Klap-in
Copy link
Collaborator

Klap-in commented Sep 10, 2020

What is the notice, warning or error message before this trace?

@Klap-in
Copy link
Collaborator

Klap-in commented Sep 10, 2020

On that line SitemapItem is used. In the last release it renamed to \dokuwiki\Sitemap\Item https://github.com/splitbrain/dokuwiki/tree/master/inc/Sitemap. It is a good idea to report this in the issue tracker of that plugin.

@mprins
Copy link
Contributor

mprins commented Sep 11, 2020

@wisze please open a PR for https://github.com/mprins/dokuwiki-plugin-spatialhelper/blob/master/action.php if you want this fixed quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants