files present in source code are listed in 'deleted.files '

[uvelokk]

The problem

Some of the files which are listed in ./data/deleted.files are (still?) present in the source code:

• vendor/paragonie/random_compat/composer.json
• vendor/paragonie/random_compat/LICENSE
• vendor/paragonie/random_compat/psalm-autoload.php
• vendor/paragonie/random_compat/psalm.xml
• vendor/paragonie/random_compat/lib/random.php

Version of DokuWiki

2024-02-06a "Kaos"

PHP Version

8.2

Webserver and version of webserver

No response

Browser and version of browser, operating system running browser

No response

Additional environment information

No response

Relevant logs and/or error messages

No response

[fiwswe]

Did you follow the upgrade instructions including the Removing Unused Files step?

[splitbrain]

Confirmed.

https://github.com/dokuwiki/dokuwiki/blob/master/data/deleted.files#L59-L70

https://github.com/dokuwiki/dokuwiki/tree/master/vendor/paragonie/random_compat

Seems like we had this library at some point, then removed it in 2022, then it got readded as dependency when we updated to phpseclib3.

[xrat]

I'd appreciate a notice at the top of deleted.files that despite what it looks like at the top (right now) lines had actually been removed since 2022-06-26. That is for now and until #4217 gets resolved.

[splitbrain]

@xrat I'm not sure I understand what you're asking for. Feel free to provide a PR.

[xrat]

I meant that any changes made to deleted.files should be documented within the file itself. But since my last comment I figured it's not really a problem. I just need to change my workflow when upgrading: I need to remove files listed in deleted.files first, and only then do the upgrade.

[xrat]

Looking at my upgrade procedure like I have done it for way more than a decade ;) I see I always deleted first and unpacked afterwards. However, upgrade instructions in the wiki actually suggest a different order:

Step 4: Unpack the distribution tarball and upload/copy the files over your previous installation. (…)
Step 5: Delete all unused files