Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Manager error with Release 2024-02-06a "Kaos" & Bootstrap3 #4251

Open
Calistenie opened this issue Mar 29, 2024 · 0 comments
Open

Media Manager error with Release 2024-02-06a "Kaos" & Bootstrap3 #4251

Calistenie opened this issue Mar 29, 2024 · 0 comments
Labels

Comments

@Calistenie
Copy link

The problem

After installation Release 2024-02-06a "Kaos" there is a probleme when you are in edit mode of a page and you click to add an image to access to the media manager.
the pop-up window to add à media let appears an error message :

Warning: Undefined array key "id" in C:\wamp64\www\dokuwikidavid\inc\Menu\Item\Edit.php on line 42

Version of DokuWiki

2024-02-06a "Kaos"

PHP Version

8.3

Webserver and version of webserver

Apache 2.4 on Windows

Browser and version of browser, operating system running browser

Firefox 124.0.1 on Windows

Additional environment information

No response

Relevant logs and/or error messages

Warning: Undefined array key "id" in C:\wamp64\www\dokuwikidavid\inc\Menu\Item\Edit.php on line 42
Call Stack
#	Time	Memory	Function	Location
1	0.0003	366176	{main}( )	...\mediamanager.php:0
2	0.1159	482096	include( 'C:\wamp64\www\dokuwikidavid\lib\tpl\bootstrap3\mediamanager.php )	...\mediamanager.php:130
3	0.1160	482448	require_once( 'C:\wamp64\www\dokuwikidavid\lib\tpl\bootstrap3\tpl\global.php )	...\mediamanager.php:13
4	0.1280	486944	dokuwiki\template\bootstrap3\Template::getInstance( )	...\global.php:32
5	0.1280	487512	dokuwiki\template\bootstrap3\Template->__construct( )	...\Template.php:121
6	0.1282	488032	dokuwiki\template\bootstrap3\Template->initToolsMenu( )	...\Template.php:36
7	0.1484	506952	dokuwiki\Menu\AbstractMenu->getItems( )	...\Template.php:2329
8	0.1484	507576	dokuwiki\Extension\Event::createAndTrigger( $name = 'MENU_ITEMS_ASSEMBLY', $data = ['view' => 'page', 'items' => []], $action = [0 => class dokuwiki\template\bootstrap3\Menu\PageMenu { protected $types = [...]; protected $context = 1; protected $view = 'page' }, 1 => 'loadItems'], $canPreventDefault = ??? )	...\AbstractMenu.php:45
9	0.1484	507736	dokuwiki\Extension\Event->trigger( $action = [0 => class dokuwiki\template\bootstrap3\Menu\PageMenu { protected $types = [...]; protected $context = 1; protected $view = 'page' }, 1 => 'loadItems'], $enablePrevent = TRUE )	...\Event.php:200
10	0.1484	507952	call_user_func_array:{C:\wamp64\www\dokuwikidavid\inc\Extension\Event.php:134}( $callback = [0 => class dokuwiki\template\bootstrap3\Menu\PageMenu { protected $types = [...]; protected $context = 1; protected $view = 'page' }, 1 => 'loadItems'], $args = [0 => ['view' => 'page', 'items' => [...]]] )	...\Event.php:134
11	0.1484	508024	dokuwiki\Menu\AbstractMenu->loadItems( $data = ['view' => 'page', 'items' => []] )	...\Event.php:134
12	0.1494	508480	dokuwiki\Menu\Item\Edit->__construct( )	...\AbstractMenu.php:61
Sélection de fichiers

edit.php :
<?php

namespace dokuwiki\Menu\Item;

/**
 * Class Edit
 *
 * Most complex item. Shows the edit button but mutates to show, draft and create based on
 * current state.
 */
class Edit extends AbstractItem
{
    /** @inheritdoc */
    public function __construct()
    {
        global $ACT;
        global $INFO;
        global $REV;

        parent::__construct();

        if ($ACT === 'show') {
            $this->method = 'post';
            if ($INFO['writable']) {
                $this->accesskey = 'e';
                if (!empty($INFO['draft'])) {
                    $this->type = 'draft';
                    $this->params['do'] = 'draft';
                } else {
                    $this->params['rev'] = $REV;
                    if (!$INFO['exists']) {
                        $this->type = 'create';
                    }
                }
            } else {
                if (!actionOK("source")) throw new \RuntimeException("action disabled: source");
                $params['rev'] = $REV;
                $this->type = 'source';
                $this->accesskey = 'v';
            }
        } else {
            if (auth_quickaclcheck($INFO['id']) < AUTH_READ) throw new \RuntimeException("no permission to read");
            $this->params = ['do' => ''];
            $this->type = 'show';
            $this->accesskey = 'v';
        }

        $this->setIcon();
    }

    /**
     * change the icon according to what type the edit button has
     */
    protected function setIcon()
    {
        $icons = [
            'edit' => '01-edit_pencil.svg',
            'create' => '02-create_pencil.svg',
            'draft' => '03-draft_android-studio.svg',
            'show' => '04-show_file-document.svg',
            'source' => '05-source_file-xml.svg'
        ];
        if (isset($icons[$this->type])) {
            $this->svg = DOKU_INC . 'lib/images/menu/' . $icons[$this->type];
        }
    }
}
@Calistenie Calistenie added the Bug label Mar 29, 2024
@Calistenie Calistenie changed the title Medai Manager error with Release 2024-02-06a "Kaos" & Bootstrap3 Media Manager error with Release 2024-02-06a "Kaos" & Bootstrap3 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant