Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio media has no source for external audio files in html5 audio tag #779

Closed
Klap-in opened this issue Jul 3, 2014 · 3 comments · Fixed by #826
Closed

Audio media has no source for external audio files in html5 audio tag #779

Klap-in opened this issue Jul 3, 2014 · 3 comments · Fixed by #826
Labels

Comments

@Klap-in
Copy link
Collaborator

Klap-in commented Jul 3, 2014

The function media_alternativefiles() does not recognize external urls, it assumes everything is a media id, so no source files are given for an external media source. https://github.com/splitbrain/dokuwiki/blob/master/inc/media.php#L2177

Called from _audio() https://github.com/splitbrain/dokuwiki/blob/master/inc/parser/xhtml.php#L1682

Probably same issue for videos displayed with html5 video tag.

@dgy18787
Copy link

is there any temp patch for this?

@Klap-in
Copy link
Collaborator Author

Klap-in commented Jul 16, 2014

A workaround is displaying the file as only a link, e.g.:

{{http://example.com/audio.mp3?linkonly|Audio file as link}}

@dgy18787
Copy link

Now I insert html codes into page to generate a html5 player which is some inconvenient...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants