Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The zip file does not contain a DolbyIO directory #44

Closed
adamallaf opened this issue Jan 24, 2023 · 4 comments
Closed

The zip file does not contain a DolbyIO directory #44

adamallaf opened this issue Jan 24, 2023 · 4 comments
Labels
CICD Related to CI/CD docs Needs documentation update enhancement New feature or request

Comments

@adamallaf
Copy link
Contributor

There is no DolbyIO directory containing the plugin in the zip file and instead the directories/files are in the zip's root, which requires the user to create DolbyIO/ directory inside Plugins/ and then extract the zip to Plugins/DolbyIO/.

image

@kubaau
Copy link
Contributor

kubaau commented Jan 24, 2023

This is not 100% accurate but is also valid. You don't need the folder to be named DolbyIO. The readme is purposely vague about this because we know zipping to be an issue: #34.

I can propose a short-term solution and a long-term one:

  • (short) make it clear in readme to extract to folder named such-and-such
  • (long) change the way we create the zips - this has already proven a problem and would require further investigation @msobo1

@kubaau kubaau self-assigned this Jan 24, 2023
@kubaau kubaau added docs Needs documentation update enhancement New feature or request good first issue Good for newcomers labels Jan 24, 2023
@kubaau kubaau removed their assignment Jan 24, 2023
@kubaau
Copy link
Contributor

kubaau commented Jan 24, 2023

@adamallaf Could you coordinate with @mhelf-dolby how you would like the readme to be reworded?

@kubaau kubaau changed the title 1.1.1-beta.4 - The zip file does not contain a DolbyIO directory 1.0.0-beta.4 - The zip file does not contain a DolbyIO directory Jan 24, 2023
@kubaau kubaau added Windows CICD Related to CI/CD labels Jan 28, 2023
@kubaau kubaau changed the title 1.0.0-beta.4 - The zip file does not contain a DolbyIO directory v1.0.0-beta.4: The zip file does not contain a DolbyIO directory Jan 28, 2023
@kubaau kubaau changed the title v1.0.0-beta.4: The zip file does not contain a DolbyIO directory The zip file does not contain a DolbyIO directory Jan 28, 2023
@kubaau
Copy link
Contributor

kubaau commented Feb 8, 2023

@adamallaf 👆🏻

@kubaau kubaau added the wontfix This will not be worked on label Feb 16, 2023
@kubaau kubaau closed this as completed Feb 16, 2023
@kubaau kubaau reopened this Feb 23, 2023
@kubaau kubaau removed wontfix This will not be worked on good first issue Good for newcomers labels Mar 2, 2023
@kubaau
Copy link
Contributor

kubaau commented Jun 10, 2023

I checked the 1.1.0-beta.6 releases and they seem to be packaged as expected.

@kubaau kubaau closed this as completed Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Related to CI/CD docs Needs documentation update enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants