DolphinQt: Allow forcing light or dark style on Windows. #12272
Conversation
|
LGTM. (untested) |
|
Yes, that was my intent, but if someone has a better idea how to differentiate them I'm all ears. |
This makes it so that if you just want to reload the current style (eg. on program start, or in response to a system event), you don't need to know the name of the currently selected user style. It's also more consistent with the way the 'userstyle/enabled' flag works.
…dark style can be manually selected.
AdmiralCurtiss
force-pushed
the
dark-mode-gui
branch
from
de436c4
to
ed6014d
Compare
|
The UI looks perfect to me. One nitpick, though, the title bars don't seem to follow a forced dark mode, e.g. forcing dark mode while Windows is in light mode will render light title bars (forcing light mode while Windows is in dark mode will correctly apply light title bars, though). Could you fix that, so a forced dark mode render dark title bars, regardless of the Windows setting? It would be nice if this could be extended to the other desktop OSes we support at some point... |
… bars on Windows.
|
Better now? You may have to restart Dolphin after changing the theme to get the correct result for the title bars. |
|
I got stuck looking for a way to do this in macOS. I'm not well versed in Objective C APIs. Good on you for getting this done 😃 |
This has been requested a few times since the introduction of the Windows dark style. #12180 also attempted to do this but it seemingly stalled out.
Windows-only for now. I'd have to investigate if there's a way to override the system style when it's automatically managed by Qt for the other OSes.
UI-wise, this reuses the User Style dropdown to now also switch between System, Light, and Dark. (On OSes other than Windows Light and Dark will not be in the dropdown.) The checkbox to enable user styles has been removed, the dropdown is now always visible and shows both our builtin and the user styles.
Before:
After:
