Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot sometimes fails to delete original embed of posted github links #32

Closed
Al12rs opened this issue Nov 4, 2020 · 3 comments
Closed

Comments

@Al12rs
Copy link

Al12rs commented Nov 4, 2020

Sometimes posting a link to github stuff still leaves the embed of the user posted message, while I understand that this bot tries to remove it since it proposes it's own embeds.
Example:
image

This makes some of the features of this bot a feel redundant and messy at times.

@dolphingarlic
Copy link
Owner

This seems to be an issue with Discord, since reloading the page almost always gets rid of the first embed. Do you think I should just disable the embed with the repo information?

@Al12rs
Copy link
Author

Al12rs commented Nov 5, 2020

From the readme you mention these as handled, but I'm not sure which types of links are actually handled
image
I saw that the bot does repo and PR links, didn't look like issues links were handled.

The repo link does give some more info, but usually the link is posted to be clicked on in those cases.

Rather than removing the feature though, how about allowing users with Manage Server permission to toggle features on and off of the bot?
Like maybe a g;toggle <featureName> command and then name of the feature. The g;help toggle command could list the feature names and what they do.

This can be a more general solution that would allow people to disable features that they don't need/like.

@dolphingarlic
Copy link
Owner

The bot doesn't use a database, so I don't think the toggling would be possible :(

I think I'll just disable the repo embed thing since this seems to happen quite often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants