Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt version needs --verbose flag that includes commit hash and timestamp #1035

Closed
zachmu opened this issue Nov 17, 2020 · 5 comments
Closed
Labels
cli enhancement New feature or request good first issue Good for newcomers sql Issue with SQL

Comments

@zachmu
Copy link
Member

zachmu commented Nov 17, 2020

Also the --help option does nothing for the version command.

@zachmu
Copy link
Member Author

zachmu commented Nov 17, 2020

For SQL, this should be a single-row static system table dolt_version

@oscarbatori
Copy link
Contributor

@zachmu is that the commit hash of the build?

@oscarbatori oscarbatori added sql Issue with SQL cli labels Nov 19, 2020
@zachmu zachmu added enhancement New feature or request good first issue Good for newcomers labels Aug 10, 2021
@zachmu
Copy link
Member Author

zachmu commented Aug 10, 2021

Yes, this needs the commit commit hash that dolt was built at, as well as the timestamp of that commit.

@Hydrocharged
Copy link
Contributor

Just the commit hash of the most recently released version, or dev builds as well?

@zachmu
Copy link
Member Author

zachmu commented Dec 5, 2023

I'm not sure what my original intent was here, you can get the commit hash from the release number since it's a tag on the repo. This doesn't add much of anything. It would be cool for development builds, but that's also where it's hardest to implement. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement New feature or request good first issue Good for newcomers sql Issue with SQL
Projects
None yet
Development

No branches or pull requests

3 participants