Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent branch deletion when another client has a session open on it #2296

Closed
zachmu opened this issue Oct 27, 2021 · 1 comment
Closed

Prevent branch deletion when another client has a session open on it #2296

zachmu opened this issue Oct 27, 2021 · 1 comment

Comments

@zachmu
Copy link
Member

zachmu commented Oct 27, 2021

Right now we prevent deleting the last branch in a DB, or the currently checked out branch. We should also prevent deleting any branch that any open session has checked out, and potentially any branch that has uncommitted changes on its respective working set.
@timsehn
Copy link
Sponsor Contributor

timsehn commented Aug 30, 2022

Closing in favor of #1841. the dolt_branch() stored procedure already checks for all the right things before deleting.

@timsehn timsehn closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachmu @timsehn