Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOLT_MERGE should return detailed error #2315

Closed
liuqianhong6007 opened this issue Nov 1, 2021 · 2 comments
Closed

DOLT_MERGE should return detailed error #2315

liuqianhong6007 opened this issue Nov 1, 2021 · 2 comments

Comments

@liuqianhong6007
Copy link

liuqianhong6007 commented Nov 1, 2021

The CLI dolt merge works well as shown
image

However, SELECT DOLT_MERGE('feature1', '-no-ff', '-m', 'Merge branch feature1 into main') does't work. The repo main branch is not clean
image

It indicetes that I should use dolt commit to conclude merge.
I think maybe variable @@autocommit affects, so I print the value which has been set default true
image

Then I notice that it returns "1" that indicates something wrong. But I get no result by quering dolt_conflicts_$db table
So where can I get the detail error ?

@VinaiRachakonda
Copy link
Contributor

This is confusing on our part. dolt_merge returning 1 means there are no conflicts. I'm going to clean up the return syntax and appropriately update the documentation

@timsehn
Copy link
Sponsor Contributor

timsehn commented Aug 30, 2022

The error messages and workflow have been updated in many recent releases. This should work better now.

@timsehn timsehn closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants