Using --continue flag for dolt table import -u doesn't add any rows

[abmyii]

This may be Windows-only. The version used was 0.37.0. The output info showed that the rows were added and Import successful, but the changes didn't persist.

[VinaiRachakonda]

Can you provide a repro?

[abmyii]

OK, this isn't Windows-only, but it seems to be specific to the setup of the us-housing-prices database (perhaps the constraints?). To test, run dolt table import -u sales test.csv on the master branch. Both rows are valid except that I have changed the hour from 00 to 99 for the first sale_date.
test.csv

This also occurs on dolt 0.36.2.

[VinaiRachakonda]

1. The attached schema in the csv file is very different from the table schema. Several of the column do not align with the schema, making it possible you are not actually updating a row to its new value.
2. This issue helped me identify a bug in our import statistics calculator that needs to get fixed.

[abmyii]

• The attached schema in the csv file is very different from the table schema. Several of the column do not align with the schema, making it possible you are not actually updating a row to its new value.

I believe it is valid, as it worked once I removed the rows being skipped manually. I removed the additional columns and tried again, with result being the same, so I do think it is a bug in the importer.

test.csv

2. This issue helped me identify a bug in our import statistics calculator that needs to get fixed.

Great!

[VinaiRachakonda]

Leaving as a note to myself. There is improper handling with --skip and violated check constraints.

[VinaiRachakonda]

Merged in master