Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown push error When pushing a branch with a 20,000 commits to DoltHub #3087

Closed
stephenctw opened this issue Mar 25, 2022 · 8 comments
Closed
Labels
bug Something isn't working

Comments

@stephenctw
Copy link

stephenctw commented Mar 25, 2022

stephen@LAPTOP-163CP44A:~/playground/dolt_pos $ dolt push --set-upstream origin experiment/explorer-1
| Tree Level: 1, Percent Buffered: 0.00%, Files Created: 2, Files Uploaded: 1, Current Upload Speed: 15 kB/s
error: push failed
cause: unknown push error; Put "https://dolthub-chunks-prod.s3.us-west-2.amazonaws.com/5ae8e9b4-ba6f-446f-85d4-d8b8a64ced4a/873tnqbg3j919ahpragjd22tgt1ot6k5?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=<>&X-Amz-Date=20220324T162157Z&X-Amz-Expires=900&X-Amz-Security-Token=<>&X-Amz-SignedHeaders=content-length%3Bcontent-md5%3Bhost&X-Amz-Signature=<>": write tcp 192.168.112.120:33946->52.92.144.66:443: write: connection reset by peer

My database is around 26 GB, the push took 15+ hours and eventually returned with this error. The upload speed is weirdly slow given my home internet plan should be ~40Mbps in upload.

I tried to upload the file (8.8GB after compression) but github won't let me. Is there a safe third party platform that I can send the file to you?

@timsehn
Copy link
Sponsor Contributor

timsehn commented Mar 25, 2022

Here's a Google Drive link.

https://drive.google.com/drive/folders/14q7e98V96nQ1o0suRlfQjegYl52j2iHq?usp=sharing

If you hit me up at tim@dolthub.com with the email you want me to add permissions to then I'll add you. Or just let me know here you don't care about it being unrestricted and I'll unlock the folder.

This is very odd. I've pushed deep commit graphs like that for the Restaurants bounty:

https://www.dolthub.com/repositories/dolthub/menus

@druvv will dig into this once we get the repo.

@fulghum fulghum added the bug Something isn't working label Mar 25, 2022
@stephenctw
Copy link
Author

File's uploaded, appreciate all the help!

@druvv
Copy link
Contributor

druvv commented Mar 25, 2022

@stephenctw There was an issue with our retry logic, but it's not entirely clear what the cause of the slowdown is. Is the reported upload speed always this consistently slow for you? Or does it increase and then decrease after some time?

For now, let's see if this issue occurs with the retry logic fixed. I have a suspicion that the reported upload rate is incorrect due to way retries interact with the long running statistics gatherer that reports the upload speed. #3095 fixes the retry.

@stephenctw
Copy link
Author

The speed started with a higher number(I don't remember the exact value), then it dropped down to 15kb in a few minutes.

@timsehn
Copy link
Sponsor Contributor

timsehn commented Mar 26, 2022

I think our plan here is for you to try pushing with the new version. We think the retry logic being broken could have messed it up.

We'll let you know when it's merged. Are you comfortable building from the tip of master (https://docs.dolthub.com/introduction/installation/source)? Or should we also let you know when it goes out in a release?

@stephenctw
Copy link
Author

Sure I can try building from source.

@timsehn
Copy link
Sponsor Contributor

timsehn commented Mar 27, 2022

OK. It's not merged yet. It's still being reviewed. If you're intrepid, you can build from the branch listed in the PR :-)

@timsehn
Copy link
Sponsor Contributor

timsehn commented Aug 30, 2022

Assume this is resolved.

@timsehn timsehn closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants