Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Compatibility issue with Knex #3240

Closed
VinaiRachakonda opened this issue Apr 15, 2022 · 3 comments · Fixed by #3320
Closed

Potential Compatibility issue with Knex #3240

VinaiRachakonda opened this issue Apr 15, 2022 · 3 comments · Fixed by #3320

Comments

@VinaiRachakonda
Copy link
Contributor

Recently a user reported a Go context canceled when running Dolt server against the Knex ORM. The user mentioned that this was due to a malformed SQL query. The attempted repro was tried but I was unable to evoke the context canceled error. I am leaving this issue open in case anyone comes across it.

 const knex = require('knex')({
    client: 'mysql',
    connection: {host: '127.0.0.1', port: 3307, user: 'root', database: 'dsimple'}
  });


async function testInsert() {
    await knex('keyed').insert({ pk: 1, val: 2 }).onConflict().merge()
    await knex.raw("daosdksaok")
    await knex('keyed').insert({ pk: 1, val: 2 }).onConflict().merge()
}

testInsert()
@VinaiRachakonda
Copy link
Contributor Author

Update full repro is here: https://github.com/aleclarson/repro/tree/dolt-4-15-2022#readme

@aleclarson
Copy link

So excited for this bug to get fixed 😄

Any chance we'll see it fixed this week? 🤞

@VinaiRachakonda
Copy link
Contributor Author

VinaiRachakonda commented Apr 19, 2022

Hey @aleclarson I've been hustling to figure out the cause of this bug. It is my #1 priority. We'll definitely get a fix in by EOW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants