Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrency problems with dolt_commit() #4361

Closed
zachmu opened this issue Sep 16, 2022 · 1 comment · Fixed by #4389
Closed

concurrency problems with dolt_commit() #4361

zachmu opened this issue Sep 16, 2022 · 1 comment · Fixed by #4389
Labels
bug Something isn't working sql server Issues related to the built in SQL server

Comments

@zachmu
Copy link
Member

zachmu commented Sep 16, 2022

Multiple concurrent sessions calling dolt_commit() can fail with the error "dataset head is not ancestor of commit".

This occurs because we determine the parent of a pending commit too early in the process, before we take a lock.

@timsehn timsehn added bug Something isn't working sql server Issues related to the built in SQL server labels Sep 19, 2022
@zachmu
Copy link
Member Author

zachmu commented Sep 21, 2022

Just an update: I have a prototype of a fix for this working for the original test repro at 5x the original concurrency load. We'll get it cleaned up, add some tests, and get it shipped this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sql server Issues related to the built in SQL server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants