Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BEGIN WORK #4436

Closed
tiksn opened this issue Sep 30, 2022 · 5 comments
Closed

Support BEGIN WORK #4436

tiksn opened this issue Sep 30, 2022 · 5 comments
Assignees
Labels
bug Something isn't working sql Issue with SQL

Comments

@tiksn
Copy link
Contributor

tiksn commented Sep 30, 2022

I want to use XCA for storing certificates in Dolt repository.

With a dolt version 0.41.5 I can't do that because I am getting error

Syntax error at possition 11 near 'WORK' QMYSQL: unable to begin transation

Query is

BEGIN WORK

From MySql Documentation seams that there are many aliases for the same operation

BEGIN [WORK]
COMMIT [WORK] [AND [NO] CHAIN] [[NO] RELEASE]
ROLLBACK [WORK] [AND [NO] CHAIN] [[NO] RELEASE]
SET autocommit = {0 | 1}

It would be nice to have those aliases.

@timsehn timsehn added bug Something isn't working sql Issue with SQL labels Sep 30, 2022
@fulghum
Copy link
Contributor

fulghum commented Sep 30, 2022

Hey Tigran, thanks for opening this issue. Using Dolt as the backing store for XCA sounds like a cool idea!

Adding parser support for BEGIN WORK, COMMIT WORK, and ROLLBACK WORK should be pretty straightforward. I‘ll check with @jcor11599 and see if he‘s able to knock this one out quickly for you.

@jycor
Copy link
Contributor

jycor commented Sep 30, 2022

Hey @tiksn, do you just need the BEGIN WORK, COMMIT WORK, and ROLLBACK WORK statements? or do you need AND NO CHAIN and NO RELEASE options as well?

Do you have an example of the query being run/generated?

@jycor
Copy link
Contributor

jycor commented Oct 3, 2022

Support for this syntax has made its way to main. Feel free to build from main to test it out. Otherwise, we'll do a release sometime this week.

@jycor jycor closed this as completed Oct 3, 2022
@tiksn
Copy link
Contributor Author

tiksn commented Oct 11, 2022

@jcor11599 so far XCA works fine with Dolt SQL Server (after applying schema manually). Thanks for the feature.

@timsehn
Copy link
Sponsor Contributor

timsehn commented Oct 11, 2022

Great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sql Issue with SQL
Projects
None yet
Development

No branches or pull requests

4 participants