Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused query bindings should be an error #4481

Closed
zachmu opened this issue Jun 2, 2021 · 2 comments
Closed

Unused query bindings should be an error #4481

zachmu opened this issue Jun 2, 2021 · 2 comments
Assignees
@jycor
Labels
bug Something isn't working good first issue Good for newcomers sql Issue with SQL

Comments

@zachmu
Copy link
Member

zachmu commented Jun 2, 2021

It's possible to pass more query bindings than there are bindvars in a query. This should be an error.
@zachmu zachmu mentioned this issue Jun 2, 2021
Merged
@zachmu zachmu added the good first issue Good for newcomers label Jun 10, 2021
@zachmu zachmu closed this as completed Oct 6, 2022
@zachmu zachmu reopened this Oct 6, 2022
@zachmu
Copy link
Member Author

zachmu commented Oct 6, 2022

My PR from months ago claims to fix this but I think that's a lie. I think it's still possible to pass in more bind vars than the query contains, and this should be an error (silently swallows application bugs otherwise).

@zachmu zachmu transferred this issue from dolthub/go-mysql-server Oct 6, 2022
@timsehn timsehn added bug Something isn't working sql Issue with SQL labels Oct 6, 2022
@jycor jycor self-assigned this Dec 15, 2022
@jycor jycor mentioned this issue Dec 15, 2022
Merged
@jycor
Copy link
Contributor

jycor commented Dec 16, 2022

fix is merged to gms, main will eventually make it to dolt main

@jycor jycor closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jycor jycor

Labels
bug Something isn't working good first issue Good for newcomers sql Issue with SQL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zachmu @timsehn @jycor