Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt panic: invalid memory address or nil pointer dereference #5237

Closed
hugoribeiromsglife opened this issue Jan 27, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working panic sql Issue with SQL

Comments

@hugoribeiromsglife
Copy link

SELECT * FROM DOLT_DIFF('hash1', 'hash2','table') where TO_ID is null

The query above is working on version 0.52.3. From version 0.52.4 onwards it is breaking and logging the following:
2023-01-27T14:31:51Z ERROR [no conn] mysql_server caught panic: runtime error: invalid memory address or nil pointer dereference /usr/local/go/src/runtime/panic.go:260 (0x85fff5) /usr/local/go/src/runtime/signal_windows.go:255 (0x85ffc5) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/analyzer/apply_join.go:79 (0x1a2565d) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/transform/node.go:353 (0x16ed0b1) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/transform/node.go:330 (0x16ecfb4) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/analyzer/apply_join.go:52 (0x1a242ba) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/analyzer/batch.go:121 (0x1a2af47) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/analyzer/batch.go:65 (0x1a2a930) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/analyzer/batch.go:56 (0x1a1c424) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/analyzer/analyzer.go:603 (0x1a1c0b8) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/sql/analyzer/analyzer.go:442 (0x1abccbe) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/engine.go:443 (0x1abcb05) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/engine.go:260 (0x1abbea7) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/server/handler.go:352 (0x1bbace9) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/server/handler.go:616 (0x1bbd967) /go/pkg/mod/github.com/dolthub/go-mysql-server@v0.14.1-0.20230111220822-c687158884c6/server/handler.go:176 (0x1bb8e65) /go/pkg/mod/github.com/dolthub/vitess@v0.0.0-20230105173952-b40441dfeb0c/go/mysql/conn.go:1288 (0x106010f) /go/pkg/mod/github.com/dolthub/vitess@v0.0.0-20230105173952-b40441dfeb0c/go/mysql/conn.go:930 (0x105ced8) /go/pkg/mod/github.com/dolthub/vitess@v0.0.0-20230105173952-b40441dfeb0c/go/mysql/server.go:481 (0x1076412) /usr/local/go/src/runtime/asm_amd64.s:1594 (0x87d6e0) {}

PS: I have tried comparing the column with something else and it works e.g.
SELECT * FROM DOLT_DIFF('hash1', 'hash2','table') where TO_ID = 'test'

@timsehn timsehn added bug Something isn't working sql Issue with SQL panic labels Jan 27, 2023
@timsehn
Copy link
Sponsor Contributor

timsehn commented Jan 27, 2023

@max-hoffman can probably bang this out quickly. Seems like a bug in his system table optimizations.

@max-hoffman
Copy link
Contributor

This should fix that dolthub/go-mysql-server#1563. Testing on the dolt side will be a little tricker.

@max-hoffman
Copy link
Contributor

The related PR is merged, the fix will be present in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working panic sql Issue with SQL
Projects
None yet
Development

No branches or pull requests

3 participants