Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt verify-contraints does not check unique constraints #6320

Closed
timsehn opened this issue Jul 12, 2023 · 1 comment · Fixed by #7679
Closed

dolt verify-contraints does not check unique constraints #6320

timsehn opened this issue Jul 12, 2023 · 1 comment · Fixed by #7679
Labels

Comments

@timsehn
Copy link
Sponsor Contributor

timsehn commented Jul 12, 2023

Related to: #6319

ricardoreiter@MacBook-Pro-de-Ricardo bug % dolt sql -q "select * from tableA"
+-------+------+------+------+-------+
| keyC  | col1 | col2 | col3 | dataA |
+-------+------+------+------+-------+
| key-b | 1    | 2    | 3    | test1 |
| key-c | 2    | 2    | 3    | test3 |
| key-d | 2    | 2    | 3    | test4 |
+-------+------+------+------+-------+

ricardoreiter@MacBook-Pro-de-Ricardo bug % dolt sql -q "CALL DOLT_VERIFY_CONSTRAINTS()"
+------------+
| violations |
+------------+
| 0          |
+------------+
@fulghum
Copy link
Contributor

fulghum commented Mar 28, 2024

I've got a prototype that reuses the existing merge logic and finds constraint violations from within dolt_verify_constraints(). It seems like this approach will work, but still needs lots more testing and figuring out a way to pull out the collected violation info from the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants