Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic due to invalid cast #6379

Closed
macneale4 opened this issue Jul 24, 2023 · 1 comment
Closed

Panic due to invalid cast #6379

macneale4 opened this issue Jul 24, 2023 · 1 comment
Labels
bug Something isn't working panic sql Issue with SQL

Comments

@macneale4
Copy link
Contributor

$ dolt init
$ dolt sql -q "show variables where 'blah'"

Should probably result in an error message like can't convert a string to a boolean. Instead, I get this panic:

$ dolt sql -q "show variables where 'blah'";
panic: interface conversion: interface {} is string, not bool

goroutine 1 [running]:
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).buildShowVariables(0x14000692990?, 0x14000c5ff40, 0x140006927b0, {0x1051829e0?, 0x1053c4628?, 0xb1b0?})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/show.go:532 +0x358
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).buildNodeExec(0x40?, 0x104f4ac00?, {0x1053c4238?, 0x140006927b0?}, {0x0?, 0x0, 0x0})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/node_builder.gen.go:105 +0xddc
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).Build(...)
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/builder.go:33
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).buildTransactionCommittingNode(0x140016aec68?, 0x104158ad0?, 0x140016aed68?, {0x0?, 0x14000c5ff40?, 0x0?})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/transaction.go:305 +0x3c
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).buildNodeExec(0x1053c3788?, 0x14000692990?, {0x1053c4628?, 0x1400069b1b0?}, {0x0?, 0x1053c3788?, 0x14000692990?})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/node_builder.gen.go:37 +0x114
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).Build(...)
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/builder.go:33
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).buildQueryProcess(0x0?, 0x10538b158?, 0x14000692990, {0x0?, 0xfbcfee6c25819b65?, 0xd64de8fe152d4009?})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/other.go:356 +0x40
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).buildNodeExec(0x140000000f5?, 0x1053a6438?, {0x1053c3788?, 0x14000692990?}, {0x0?, 0x104201840?, 0x14000c6b688?})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/node_builder.gen.go:43 +0x1a4
github.com/dolthub/go-mysql-server/sql/rowexec.(*BaseBuilder).Build(0x140001b1ae0?, 0x14000c5ff40?, {0x1053c3788?, 0x14000692990?}, {0x0?, 0x140006927b0?, 0x140016b0001?})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/sql/rowexec/builder.go:33 +0x28
github.com/dolthub/go-mysql-server.(*Engine).QueryNodeWithBindings(0x140001b1ae0, 0x14000c5ff40, {0x140001e6be0, 0x1b}, {0x0?, 0x0?}, 0xf0?)
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/engine.go:311 +0x25c
github.com/dolthub/go-mysql-server.(*Engine).QueryWithBindings(...)
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/engine.go:249
github.com/dolthub/go-mysql-server.(*Engine).Query(0x140016af258?, 0x102c5ddf4?, {0x140001e6be0?, 0x140016af278?})
        /Users/neil/go/pkg/mod/github.com/dolthub/go-mysql-server@v0.16.1-0.20230718175229-3072091ce8c9/engine.go:244 +0x2c
github.com/dolthub/dolt/go/cmd/dolt/commands/engine.(*SqlEngine).Query(0x140016af288?, 0x102c711f0?, {0x140001e6be0?, 0x105350880?})
        /Users/neil/Documents/dolt/go/cmd/dolt/commands/engine/sqlengine.go:248 +0x24
github.com/dolthub/dolt/go/cmd/dolt/commands.processParsedQuery(0x140001e6be0?, {0x140001e6be0?, 0x1b?}, {0x1053995e0?, 0x1400009a4b0?}, {0x1053a8800?, 0x140003901e0?})
        /Users/neil/Documents/dolt/go/cmd/dolt/commands/sql.go:1007 +0x3c0
github.com/dolthub/dolt/go/cmd/dolt/commands.execBatchMode(0x14000c5ff40, {0x1053995e0, 0x1400009a4b0}, {0x10539fb20?, 0x14000cb8f60}, 0x0, 0x0?)
        /Users/neil/Documents/dolt/go/cmd/dolt/commands/sql.go:634 +0x3b0
github.com/dolthub/dolt/go/cmd/dolt/commands.queryMode(0x10500f160?, {0x1053995e0, 0x1400009a4b0}, 0x4?, {0x16d1f7754, 0x1b}, 0x2?, 0x2?)
        /Users/neil/Documents/dolt/go/cmd/dolt/commands/sql.go:388 +0xc4
github.com/dolthub/dolt/go/cmd/dolt/commands.SqlCmd.Exec({{0x104538844?, 0x156373ee879df78e?}}, {0x1053b3a28, 0x1400057a4b0}, {0x14000c6b2e0, 0x8}, {0x140001a4060, 0x2, 0x2}, 0x140006c3ef0, ...)
        /Users/neil/Documents/dolt/go/cmd/dolt/commands/sql.go:210 +0x3f8
github.com/dolthub/dolt/go/cmd/dolt/cli.SubCommandHandler.handleCommand({{0x104537dc7, 0x4}, {0x1045576a7, 0x11}, {0x0, 0x0}, {0x107cca0e0, 0x32, 0x32}, 0x0}, ...)
        /Users/neil/Documents/dolt/go/cmd/dolt/cli/command.go:244 +0x3e8
github.com/dolthub/dolt/go/cmd/dolt/cli.SubCommandHandler.Exec({{0x104537dc7, 0x4}, {0x1045576a7, 0x11}, {0x0, 0x0}, {0x107cca0e0, 0x32, 0x32}, 0x0}, ...)
        /Users/neil/Documents/dolt/go/cmd/dolt/cli/command.go:193 +0x258
main.runMain()
        /Users/neil/Documents/dolt/go/cmd/dolt/dolt.go:542 +0x23f4
main.main()
        /Users/neil/Documents/dolt/go/cmd/dolt/dolt.go:201 +0x1c
@jycor
Copy link
Contributor

jycor commented Jul 25, 2023

Fix is merged and making its way to dolt main.

@jycor jycor closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working panic sql Issue with SQL
Projects
None yet
Development

No branches or pull requests

3 participants