undefined ViewSelectPositionStart & ViewSelectPositionEnd

[nathan-fiscaletti]

I'm getting this on both macOS and Linux running go1.14 (I get it during installation of the package and then when I try to compile a program that uses the package)

# github.com/liquidata-inc/go-mysql-server/sql/parse
../go/src/github.com/liquidata-inc/go-mysql-server/sql/parse/parse.go:792:22: c.ViewSelectPositionStart undefined (type *sqlparser.DDL has no field or method ViewSelectPositionStart)
../go/src/github.com/liquidata-inc/go-mysql-server/sql/parse/parse.go:792:48: c.ViewSelectPositionEnd undefined (type *sqlparser.DDL has no field or method ViewSelectPositionEnd)

[zachmu]

H Nathan,

Thanks for notifying us. We're deploying a fix momentarily and will let you know when we have.

[zachmu]

This is now fixed on master. I just ran all tests on master and they pass. Please confirm.

I'm a little confused how you ran into this. The breaking change you're talking about was introduced into liquidata-inc/vitess, but liquidata-inc/go-mysql-server didn't update its version of the same until that most recent PR (which also updated the symbols to fix the break). Did you run go get for the @master version of vitess?

[nathan-fiscaletti]

I discovered this library and went to test it out using the sample code in the read-me when I ran into it.

I only ran the two following go get commands to test it.

$ go get github.com/liquidata-inc/go-mysql-server
$ go get github.com/stretchr/testify/require

All of this happened maybe 10m before actually creating the issue here. So I'm as confused as you are 🤷‍♂️

[zachmu]

Well, should be fixed now regardless. Thanks for the report!