Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choosenim update self throws HttpRequest Error #116

Closed
euantorano opened this issue Apr 26, 2019 · 6 comments
Closed

choosenim update self throws HttpRequest Error #116

euantorano opened this issue Apr 26, 2019 · 6 comments

Comments

@euantorano
Copy link
Contributor

PS C:\Users\euant> choosenim update self
   Updating choosenim
[#                                                 ] 0mb 3kb/s
choosenim.nim(206)       choosenim
choosenim.nim(183)       performAction
choosenim.nim(132)       update
choosenim.nim(107)       updateSelf
download.nim(192)        downloadFile
download.nim(177)        downloadFileNim
httpclient.nim(1306)     downloadFile
Error: unhandled exception: 404 Not Found [HttpRequestError]

OS: Windows 10 Enterprise x64

Version: choosenim v0.3.2 (2018-02-27 20:19:49) [windows/i386]

Since choosenim update self is the recommended way to update choosenim, it would be nice to catch and handle these types of exceptions to provide a little more information (e.g. which URL caused the 404).

@dom96
Copy link
Owner

dom96 commented Apr 27, 2019

This is a bug in choosenim (exceptions should always be handled)

Run choosenim update self --debug to get info about the URL. I think I know how to fix this though.

@dom96
Copy link
Owner

dom96 commented Apr 27, 2019

Bah. Looks like choosenim won't add the .exe to the URL: https://github.com/dom96/choosenim/blob/v0.4.0/src/choosenim.nim#L82. And GitHub won't let me save an .exe binary without the .exe extension :(

@genotrance
Copy link
Collaborator

Is all that's needed is an addFileExt(ExeEct)?

@dom96
Copy link
Owner

dom96 commented Jan 12, 2020

Possibly. But AFAIK we'll get "File is in use" errors when copying over choosenim.exe anyway because of how Windows works.

@genotrance
Copy link
Collaborator

Does this mean we don't have choosenim self update working on Windows to date?

@dom96
Copy link
Owner

dom96 commented Jan 12, 2020

Yes, I doubt it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants