Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to contribute JsonExtensionDataAttribute feature... #389

Closed
CodeBlanch opened this issue May 4, 2017 · 3 comments
Closed

Would like to contribute JsonExtensionDataAttribute feature... #389

CodeBlanch opened this issue May 4, 2017 · 3 comments

Comments

@CodeBlanch
Copy link
Contributor

Sorry I am new to GitHub this was the only way I could find to send a message!

I added support for building additionalProperties off of JsonExtensionDataAttribute. Please give me contrib permission so I can open a PR.

Basically given...

public class SomeType
{
public bool Property1 { get; set; }
[JsonExtensionData]
public IDictionary<string, object> ExtensionData { get; set; }
}

Generate...

SomeType:
type: "object"
properties:
Property1:
type: "boolean"
additionalProperties:
type: "object"

@mclark1129
Copy link

mclark1129 commented May 8, 2017

Fork the repo into your own account, from there you should be able to submit a PR from your repo into the main one.

@CodeBlanch
Copy link
Contributor Author

Done!

@domaindrivendev
Copy link
Owner

Thanks @CodeBlanch. Should be released as of v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants