Newlines collapsed with custom converter

[hsmallbone]

I have some HTML which looks like this:

<pre>
<code>
line 1
<br>
<br>
line 2
<br>
<br>
<br>
line 3
</code>
</pre>

and a custom converter like this (using GFM):

                {
                    filter: function (node) {
                        return node.nodeName === 'PRE' &&
                            node.firstChild &&
                            node.firstChild.nodeName === 'CODE';
                    },
                    replacement: function (content, node) {
                        return '```\n' + content + '\n```';
                    }
                }

The end result looks like this:

line 1

line 2

line 3

Instead of having two or three newlines it only keeps one, despite my filter returning the correct number of newlines between each line.

Am I going wrong somewhere in my code or is this a bug or a known issue...?

[hsmallbone]

After some investigation it appears to be related to the end of the toMarkdown function, where repeated newlines are collapsed. I'm not sure if that is correct behaviour as in this case it leads to explicit newlines being collapsed but it could be related to the spec?

[domchristie]

it appears to be related to the end of the toMarkdown function, where repeated newlines are collapsed.

Yes, correct. Repeated newlines are collapsed to tidy up the converted HTML, but as you have pointed out, this approach fails when processing repeated new lines in pre blocks.

Thanks for raising this.

[domchristie]

This behaviour is fixed in https://github.com/domchristie/turndown which is a rewrite and will supersede this project. Feel free to give it a go, and raise any issues there.