Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOME only supports 44.1k sample rate audio #113

Closed
avivbeeri opened this issue Nov 8, 2020 · 0 comments · Fixed by #144
Closed

DOME only supports 44.1k sample rate audio #113

avivbeeri opened this issue Nov 8, 2020 · 0 comments · Fixed by #144
Labels
bug Something isn't working

Comments

@avivbeeri
Copy link
Collaborator

44.1k is a good quality audio (you find it in CDs, for example), but video game audio is often provided at 48k. Trying to play files encoded for 48k results in unusual pitch shifting.

DOME needs to resample the 48k files down to 44.1k, or 44.1k->48k, whichever makes more sense.

Should we be able to support other sample rates?
@avivbeeri avivbeeri added the bug Something isn't working label Nov 8, 2020
@avivbeeri avivbeeri linked a pull request Jan 7, 2021 that will close this issue
Audio Engine re-architecting (pt1) + resampling #144
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Audio Engine re-architecting (pt1) + resampling domeengine/dome
1 participant
@avivbeeri