Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm-check fails due to peer dependency of sinon < 7.0.0 #132

Closed
stevegoossens opened this issue Oct 17, 2018 · 4 comments
Closed

npm-check fails due to peer dependency of sinon < 7.0.0 #132

stevegoossens opened this issue Oct 17, 2018 · 4 comments

Comments

@stevegoossens
Copy link

stevegoossens commented Oct 17, 2018

Sinon 7.0.0 looks like it was released 3 days ago.

sinon 6.3.5 installed

npm-check now fails, e.g.

sinon   馃槑  MAJOR UP  Major update available. https://sinonjs.org/
                     npm install --save-dev sinon@7.0.0 to go from 6.3.5 to 7.0.0

Use npm-check -u for interactive update.
npm ERR! code ELIFECYCLE
npm ERR! errno 1

sinon 7.0.0 installed

installing sinon@7.0.0 causes npm test failure due to:

npm WARN sinon-chai@3.2.0 requires a peer of sinon@>=4.0.0 <7.0.0 but none is installed. You must install peer dependencies yourself.
@pkuczynski
Copy link

This would be fixed by #131

@simondel
Copy link
Collaborator

I'm in contact with Domenic to transfer ownership to me so PR's can be merged and released.

@simondel
Copy link
Collaborator

I'll create a release today.

@simondel
Copy link
Collaborator

sinon-chai@3.3.0 has been released 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants