Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Chai 4.0 #97

Closed
layershifter opened this issue May 26, 2017 · 4 comments
Closed

Support for Chai 4.0 #97

layershifter opened this issue May 26, 2017 · 4 comments

Comments

@layershifter
Copy link

chai@4.0.0 was released recently, it will be awesome to get support of it 馃槃
@layershifter layershifter mentioned this issue May 26, 2017
Closed
@jraller
Copy link

jraller commented May 26, 2017

None of the tests fail when the devDependencies are updated to chai "^4.0.0" and the peerDependencies are changed to ">=1.9.2" for chai. I'm seeing 137 tests passing after making those changes. I have not yet completed reading the breaking changes list at https://github.com/chaijs/chai/releases/tag/4.0.0 so I don't know if additional tests are needed yet.

@domenic
Copy link
Collaborator

domenic commented May 26, 2017

Pull request welcome!

@jraller jraller mentioned this issue May 26, 2017
Closed
@eddyystop eddyystop mentioned this issue May 30, 2017
Merged
@Shockolate
Copy link

When support is merged, please update the peer dependency

@layershifter layershifter mentioned this issue Jun 1, 2017
Merged
@princed princed mentioned this issue Jun 8, 2017
Open
@bhousel bhousel mentioned this issue Jun 8, 2017
Merged
@domenic
Copy link
Collaborator

domenic commented Jun 11, 2017

Fixed by 40b35f3

@domenic domenic closed this as completed Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jraller @domenic @Shockolate @layershifter