Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should always return a string #12

Closed
le0nik opened this issue May 16, 2018 · 1 comment
Closed

Should always return a string #12

le0nik opened this issue May 16, 2018 · 1 comment

Comments

@le0nik
Copy link

le0nik commented May 16, 2018

Tried to run toUpperCase on the result and received an error when number was less than 1000.
It should always return a string for consistency.

typeof numberAbbreviate(10) === 'number'
// true
typeof numberAbbreviate(1000) === 'string'
// true
@le0nik le0nik closed this as completed May 27, 2018
@domharrington
Copy link
Owner

Hey, did you have any problems with this? Or did you figure it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domharrington @le0nik