Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphenator and Prototype framework incompatibility #36

Closed
GoogleCodeExporter opened this issue Mar 12, 2015 · 9 comments
Closed

Hyphenator and Prototype framework incompatibility #36

GoogleCodeExporter opened this issue Mar 12, 2015 · 9 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. include prototype js framework in html
2. include Hyphenator.js in html
3. test hyphenation

What is the expected output? What do you see instead?
Including/using prototype and hyphenation at the same time seems to be
impossible. Hyphenation does not work, unless prototype is excluded.

What version of the product are you using? On what operating system?
HyphenatorBeta10 on Firefoy and Safari for Mac OS 10.5, IE7 on Windows Vista

Please provide any additional information below.


Original issue reported on code.google.com by fabr...@transporter.at on 15 Dec 2008 at 1:53

@GoogleCodeExporter
Copy link
Author

Hi

I can't repoduce this issue.
Witch version of prototype did you use?
(See also: http://code.google.com/p/hyphenator/issues/detail?id=7&can=1)

thanks

Original comment by mathiasn...@gmail.com on 15 Dec 2008 at 6:01

@GoogleCodeExporter
Copy link
Author

I use the latest Prototype 1.6.0.3 and HyphenatorBeta10. The attached html 
reproduces
the issue.

Thanks for your reply.

Original comment by fabr...@transporter.at on 16 Dec 2008 at 8:23

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks

the attachment helped: I was able to reproduce the issue, but only on Firefox 
(OS X, 3.0.4) and Opera (OS X, 
9.60).
Safari (OS X, 3.2.1) and IE7 (XP) are working as exspected, here.

Original comment by mathiasn...@gmail.com on 16 Dec 2008 at 12:48

  • Changed state: Accepted
  • Added labels: Priority-High
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

You are right, my formerly attached issue.zip works well in Safari 3.2.1 OSX 
and IE7
WinVista.

But, unfortunately, I am developing a rather complex html/css/js structure. 
Including
Hyphenator within this structure only works in Safari 3.2.1 OSX, but fails in 
all
other browsers (OSX: Firefox 3.0.4, WinVista: IE7/Firefox 3.0.4, WinXP: 
IE6/Opera
9.63). Sorry.

Original comment by fabr...@transporter.at on 16 Dec 2008 at 3:04

@GoogleCodeExporter
Copy link
Author

I see. The problem is the DOMContentLoaded-Event, I use. Prototype does 
something with this, too. But I did 
not completely understand what it does...

The same problem exists with other frameworks like jQuery.

I made a quick fix for prototype.js (Revision 250: 
http://hyphenator.googlecode.com/svn/trunk/Hyphenator.js)
Nevertheless, I will have to rethink everything. I can't include an exception 
for every possible library.

Original comment by mathiasn...@gmail.com on 16 Dec 2008 at 7:09

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Fantastic, thanks a lot, the fix works for me.
At the same time I'm sorry for you that you will have to modify the script.

Anyway, keep up the good work!

Original comment by fabr...@transporter.at on 17 Dec 2008 at 9:05

@GoogleCodeExporter
Copy link
Author

You're welcome!
There's nothing to be sorry about: I need these feedbacks to bring my script to 
perfection - and there will alway 
be something to modify...

Keep looking for updates.

Thanks so long,
Regards, Mathias

Original comment by mathiasn...@gmail.com on 17 Dec 2008 at 12:32

@GoogleCodeExporter
Copy link
Author

The issue isn't as difficult to solve as I thought:

The problem is the runOnContentLoaded-function I copied from 
http://javascript.nwbox.com/ContentLoaded/: It checks a var document.load, this 
var has been set by 
prototype, too.

I changed the runOnContentLoaded to store the information in a local var 
documentloaded, instead of global 
document.loaded.

I also created a testcase 
(http://hyphenator.googlecode.com/svn/trunk/testsuite/test28.html) to check the 
compatibility with jQuery and prototype.
Other frameworks will be tested later...

Original comment by mathiasn...@gmail.com on 19 Dec 2008 at 7:18

@GoogleCodeExporter
Copy link
Author

test28 is testing for compatibility of all libraries hosted by google 
(http://code.google.com/intl/de-
DE/apis/ajaxlibs/; as of 19.12.2008).
There is currently no incompatibility.
Therefore I mark this issue as fixed.

Original comment by mathiasn...@gmail.com on 19 Dec 2008 at 8:02

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant