Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoapClient instance needed for ObserveDevice method on DeviceController #21

Closed
scheelings opened this issue Mar 15, 2019 · 1 comment
Closed

Comments

@scheelings
Copy link

Hi,

I am trying to implement the new version (1.0.0.31) of the TradfriLibrary.
When I want to observe updates on a device, so I need to call the ObserveDevice method on the DeviceController:
public CoapObserveRelation ObserveDevice(CoapClient cc, TradfriDevice device, Action<TradfriDevice> callback, Action<CoapClient.FailReason> error = null)

You'll notice that a reference to the CoapClient is needed, which is a private member of the TradfriController instance:
private CoapClient _coapClient;

Can you update the code, so the CoapClient is public visible or change the ObserveDevice method, so the CoapClient instance is not needed anymore?

Thx,
Danny

@dominicusmento
Copy link
Owner

This is also fixed by rewriting the observable part and CoapClient is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants