Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem displaying tag in <li> if tag starts with < #7

Closed
nobodynuf opened this issue Oct 14, 2022 · 2 comments
Closed

Problem displaying tag in <li> if tag starts with < #7

nobodynuf opened this issue Oct 14, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nobodynuf
Copy link

Hello,

I was making a custom tags file, and added my embeddings (textual_inversion) as tags in the form "<name_embedded>" to enable autocompletion and stuff.

After editing my target csv file I noticed that the autocomplete function filters correctly but does not show the element in the list (the tag <name_embedded> appeared like '' )

I resolved the issue escaping the < and the > symbols with the html equivalent.

The line I edited

li.innerHTML = result[0];

was replaced with
li.innerHTML = result[0].replace('<','&lt;').replace('>','&gt;');
and the issue is solved.

I mean, I know that the custom script is based on danbooru tags but maybe the scripts need html escaping to avoid those types of issues.

@DominikDoom
Copy link
Owner

Good point, I totally didn't think about HTML entities in tags. Will fix later.

@DominikDoom DominikDoom self-assigned this Oct 14, 2022
@DominikDoom DominikDoom added the bug Something isn't working label Oct 14, 2022
@DominikDoom
Copy link
Owner

Should be solved now! Let me know if it still behaves unexpected for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants