Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

megacheck: allow exclusion of tests per tool #304

Closed
ainar-g opened this issue Jul 25, 2018 · 2 comments
Closed

megacheck: allow exclusion of tests per tool #304

ainar-g opened this issue Jul 25, 2018 · 2 comments

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Jul 25, 2018

Right now megacheck has a -tests flag, which is shared across all three tools. But I always want unused to skip tests, in order to find objects that are only used in tests (see #289), but still have simple and staticcheck check my tests. Right now I have to call unused separately with -tests false, which obviously means that the check time is almost doubled.
@dominikh
Copy link
Owner

I feel like -tests=false isn't really what you want to use for unused, as that won't flag any unused identifiers that are declared in tests.

We should probably flag identifiers declared in non-test files that are only used from tests, even with -tests=true.

@dominikh
Copy link
Owner

And that would be #94

@ainar-g ainar-g mentioned this issue May 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominikh @ainar-g