Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix define fn #100

Merged
merged 19 commits into from Nov 12, 2022
Merged

Fix define fn #100

merged 19 commits into from Nov 12, 2022

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Oct 26, 2022 •
edited

  • 10bindingsIo.pm: Fix some errors in defineFn, Attributes & arguments were not parsed correctly
  • 10bindingsIo.pm: Fix duplicate define, if device is already defined via hostname
  • 10bindingsIo.pm: Added some basic tests to verify module can be loaded without errors and defineFN works
  • 10bindingsIo.pm: changed refs to subs from strings into coderefs
  • Added workflow for automatic FHEM Module testing
    • Update controls_file also on feature branches to allow usage from repository

Todo:

  • Fix lineendings

@sidey79 sidey79 marked this pull request as ready for review October 27, 2022 11:09
@sidey79
fix define function
8b01934 
- BindingsIo_Define
- remove protypes from BindingsIo_Initialize
- Store Fn References as coderefs
@sidey79
Add workflow for testing fhem module
3839477 
 use perl with multi threading support
@sidey79
added some ignores .gitignore
125fdf8
@sidey79
update setup-fhem
7e928e8
@sidey79
add plan to test
ed26355 
don't run tests parallel, because we need fhemweb with port binding

run update controls in separate job
@sidey79
Create .gitattributes
2a1b02e 
Set Line endings to crlf for perlModule files.
@sidey79
changed lineendings
259ef0b
@sidey79
declare variable from main program
5807c40
@sidey79
changed search for existing devspec to devspec2array fn
29de3b9 
add variable from main program
@sidey79
avoid duplicate defines of same device
98d0d18 
small search improvement
@github-actions
action: auto update controls
03ef2c3 
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
fhempy
fhempy requested changes Oct 31, 2022
View reviewed changes
Copy link
Owner

@fhempy fhempy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke dir für die Anpassungen! 👍

.github/workflows/fhem_test.yml Show resolved Hide resolved
FHEM/10_BindingsIo.pm Show resolved Hide resolved
FHEM/10_BindingsIo.pm Show resolved Hide resolved
FHEM/10_BindingsIo.pm Show resolved Hide resolved
FHEM/10_BindingsIo.pm Outdated Show resolved Hide resolved
FHEM/10_BindingsIo.pm Show resolved Hide resolved
t/FHEM/10_BindingsIo/00_load.t Show resolved Hide resolved
github-actions bot and others added 2 commits October 31, 2022 22:39
@github-actions @sidey79
action: auto update controls
f89f78b 
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@sidey79
added check for bindingtype
fb9aa77 
added tests
@sidey79 sidey79 requested a review from fhempy November 6, 2022 15:34
@sidey79
Copy link
Contributor Author

sidey79 commented Nov 6, 2022

@fhempy

Kann ich noch etwas für diesen PR machen?

fhempy
fhempy requested changes Nov 6, 2022
View reviewed changes
FHEM/10_BindingsIo.pm Show resolved Hide resolved
FHEM/10_BindingsIo.pm Outdated Show resolved Hide resolved
FHEM/10_BindingsIo.pm Show resolved Hide resolved
FHEM/10_BindingsIo.pm Outdated Show resolved Hide resolved
@fhempy
Copy link
Owner

fhempy commented Nov 6, 2022

Ich hatte vergessen meinen Review abzuschließen, sorry! Bitte die 2 Punkte oben noch prüfen, danke!

@github-actions
action: auto update controls
d58a3ec 
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
fhempy
fhempy requested changes Nov 12, 2022
View reviewed changes
controls_pythonbinding.txt Show resolved Hide resolved
sidey79 and others added 4 commits November 12, 2022 12:05
@sidey79
add python binary to FHEM modules updater controls file
57b0427
@github-actions
action: auto update controls
48cf5e0 
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@fhempy
Merge branch 'master' into fix-define
4759985
@github-actions
action: auto update controls
dabc910 
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fhempy fhempy merged commit f896ea4 into fhempy:master Nov 12, 2022
@sidey79 sidey79 deleted the fix-define branch November 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhempy fhempy fhempy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidey79 @fhempy