Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we make Domino._app_id a public API? #127

Open
maartenbreddels opened this issue May 20, 2022 · 1 comment
Open

Can we make Domino._app_id a public API? #127

maartenbreddels opened this issue May 20, 2022 · 1 comment

Comments

@maartenbreddels
Copy link

Hi,

Domino._app_id is now 'protected', could it be a public API? We are making a domino product that needs to generate a URL to a deployed app, and for that, we need the app_id.
Happy to make a PR for this.

Regards,

Maarten Breddels
@maartenbreddels maartenbreddels mentioned this issue May 20, 2022
Open
@ddl-alexpanin
Copy link
Contributor

Hi @maartenbreddels , please go ahead and open a PR, we'll take a look.

@maartenbreddels maartenbreddels mentioned this issue Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make app_id a public API maartenbreddels/python-domino
2 participants
@maartenbreddels @ddl-alexpanin