Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to add a negative amount for add command #5

Open
domlimm opened this issue Apr 16, 2022 · 1 comment
Open

Able to add a negative amount for add command #5

domlimm opened this issue Apr 16, 2022 · 1 comment

Comments

@domlimm
Copy link
Owner

domlimm commented Apr 16, 2022

Steps to reproduce:

Similar to Issue #4 on the edit command.

User is able to add a negative amount when adding an expense into the app.

add d/testing negative a/-1 t/2022-04-16

Expected:

A non-negative amount when adding an expense.

Actual:

image.png

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 19, 2022

Team's Response

Rejected because it is a feature flaw, not a functionality bug. In addition, this feature flaw will not affect the functionality of the application, it will just render one expense invalid due to negative value and user can re-key the value. Hence, the severity should not be high too.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Once again, sorry. I might have mixed up FeatureBug and FunctionalityBug. Agree on the change for type and severity of the issue.

However, it should still be accepted as a bug. Yes, it will not affect the functionality of the application. But in a real world application, an expense would not be negative.

And as the dev team has said, which would already cause a problem.

... it will just render one expense invalid due to negative value ...

That was the point of the bug report. In my opinion, should not be rejected because of wrong tagging.

Again, sorry for the wrong tagging!

Also, as mentioned by prof here, should not be rejected because of the wrong bug type.


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue severity

Team chose [severity.Medium]
Originally [severity.High]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants