Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying comment counts should be configurable #23

Closed
hlapp opened this issue Jan 5, 2014 · 0 comments
Closed

Displaying comment counts should be configurable #23

hlapp opened this issue Jan 5, 2014 · 0 comments

Comments

@hlapp
Copy link
Contributor

hlapp commented Jan 5, 2014

I suspect most people will want comment counts on the index (and possibly other pages) if they have Disqus-powered comments enabled. Presently that requires uncommenting code in a template page. For one, that is more technical than it should or needs to be.

Moreover, every requirement to uncomment template page content to get a feature causes a fork to permanently diverge from the main (upstream) repo's master branch, which in turn makes submitting clean pull requests (i.e., pull requests that don't contain the diverging commits) an increasing hassle.

So ideally, there is no need to ever uncomment - everything is controlled by config variables. The next best thing is that at least features more commonly desired or useful be controlled by config variables and not commenting/uncommenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant