Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join command runs out of memory #1317

Closed
thecatontheflat opened this issue Mar 16, 2024 · 2 comments
Closed

Join command runs out of memory #1317

thecatontheflat opened this issue Mar 16, 2024 · 2 comments
Labels
duplicate This issue or pull request already exists package:functions performance

Comments

@thecatontheflat
Copy link

Describe the bug
After eating 31GB of RAM the process gets OOM-killed

To Reproduce
Steps to reproduce the behavior:

  1. Install v4 alpha
npm install --global @gltf-transform/cli@next @gltf-transform/core@next @gltf-transform/extensions@next @gltf-transform/functions@next
  1. Download the attached GLTF (700MB unpacked)
    https://www.dropbox.com/scl/fi/q1uisxtqoe7hj4d5gzm1r/world.zip?rlkey=1gt9q5t4ns9v8xwwx8gy6geo2&dl=0

  2. Run the following command to join meshes

gltf-transform join world.gltf world-transformed.glb
  1. OOM Killed 💀

Versions:

  • Version: 4.0.0-alpha.10
  • Environment: node
@donmccurdy
Copy link
Owner

donmccurdy commented Mar 16, 2024

Thanks for the report, @thecatontheflat! I think this issue has the same root cause as #1315, so I'm going to merge the two issues. I've copied over some details from this report as well. If you need a workaround in the meantime, I found that running weld first, followed by join, will complete. The weld step is still slow (also tracked by the issue above), but keeps a more reasonable memory footprint for a file this size.

@donmccurdy donmccurdy closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2024
@donmccurdy donmccurdy added duplicate This issue or pull request already exists package:functions performance and removed bug Something isn't working labels Mar 16, 2024
@thecatontheflat
Copy link
Author

The workaround has worked! Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists package:functions performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants