Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Draco and Meshopt compression implementations #1386

Open
donmccurdy opened this issue May 2, 2024 · 0 comments
Open

Simplify Draco and Meshopt compression implementations #1386

donmccurdy opened this issue May 2, 2024 · 0 comments

Comments

@donmccurdy
Copy link
Owner

donmccurdy commented May 2, 2024

Meshopt

Currently glTF Transform's Meshopt implementation has its own accessor writing method, and doesn't support VertexLayout options. I think possibly glTF Transform could just write Meshopt-compatible buffer view layouts by default, and simplify the Meshopt implementation accordingly.


Draco

The Draco implementation currently has to duplicate accessors in rare situations, leading to complex bugs. It may be worth a change to require pre-processing with draco(), and failing if Draco compression is attempted when that pre-processing has not been applied. Or other simplifications may be possible.

@donmccurdy donmccurdy added this to the 🗄️ Backlog milestone May 2, 2024
@donmccurdy donmccurdy changed the title Clean up meshopt and draco compression implementations Simplify Draco and Meshopt compression implementations May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant