-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Provides option to toggle light/dark mode #48
Comments
You need a plugin to apply the theme of your wiki to the app. See FAQ :) |
Thank you for your reply, I have tried it, but I think you have misunderstood what I mean, the options in the plugin change the color of the system bar, my request is not to follow the system light and dark settings by default to enable |
You mean applying force light/dark, but not setting theme color? |
Wait.. why apply |
|
In fact Tiddloid reads data from current palette, not theme. Themes and palettes in TiddlyWiki are set separately. |
Yes, I've read that source code, what I mean is that the |
Hmmmmmmm... I thought the WebView just notifies the page that should be in dark mode and renders background (if not changed by the page) and some widgets darkened... So you think the webview does something more than abobe, or it overrides the settings of the page? |
Okay I may remove this line in next update since is not properly handled by TW. |
Well, this should have been a nice feature.. 😢 |
It's not a new feature XD... In the 1.x era there's a "Colorful Update" (1.4.0/lite 1.2.0) which introduced the tweak plugin and theme colors. The |
I'll remove |
It's weird that on my physical device (a Redmi) the page is properly rendered... That's why I didn't see anything wrong, maybe XD |
Maybe it's because my system's WebView version (78.0) is too old... 😣 |
Hmmmmm... I just remembered once the page rendered incorrectly in avd, even the |
Does anyone still have problem? I may close this if no problem reported. |
I'm glad you've provided the ability to force a dark theme in version 2.3.1, but that feature is toggled with the system settings. However, I had already customized the dark theme in my TiddlyWiki file and enabling
setForceDark()
would cause color misalignment, so I would like you to provide the option for the user to fix the light/dark theme themselves.PS: Thanks for bringing the legacy local loading option back!
The text was updated successfully, but these errors were encountered: